Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of random_string #1584

Merged
merged 1 commit into from Apr 9, 2019
Merged

Fix typo of random_string #1584

merged 1 commit into from Apr 9, 2019

Conversation

dunse
Copy link
Contributor

@dunse dunse commented Apr 4, 2019

To fix this error:

[warn]: emit transaction failed: error_class=NameError error="undefined local variable or method `random_string' for #<Fluent::SyslogOutput:0x007f553ed585c8>" location="/etc/fluent/plugin/out_syslog.rb:126:in `block in emit'"

@dunse
Fix typo of random_string
1676860 
To fix this error:
`[warn]: emit transaction failed: error_class=NameError error="undefined local variable or method `random_string' for #<Fluent::SyslogOutput:0x007f553ed585c8>" location="/etc/fluent/plugin/out_syslog.rb:126:in `block in emit'"`
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2019
@openshift-ci-robot
Copy link

Hi @dunse. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2019
@jcantrill
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2019
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@richm richm added approved Indicates a PR has been approved by an approver from all required OWNERS files. autoretest Please auto-retest this PR if one of the flaky tests fail backport/3.10 backport/3.11 backport/3.9 backport this PR to release-3.9 component/fluentd kind/bug Categorizes issue or PR as related to a bug. release/4.1 labels Apr 8, 2019
@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

9 similar comments
@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

7 similar comments
@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

6 similar comments
@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 8, 2019

/retest

@richm
Copy link
Contributor

richm commented Apr 9, 2019

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 27976ce into openshift:master Apr 9, 2019
@richm
Copy link
Contributor

richm commented Apr 9, 2019

/cherrypick release-3.11

@richm
Copy link
Contributor

richm commented Apr 9, 2019

/cherrypick release-3.10

@richm
Copy link
Contributor

richm commented Apr 9, 2019

/cherrypick release-3.9

@openshift-cherrypick-robot
Copy link

@richm: new pull request created: #1589

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2019
Merged
@openshift-cherrypick-robot
Copy link

@richm: new pull request created: #1590

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 9, 2019
Merged
Merged
@openshift-cherrypick-robot
Copy link

@richm: new pull request created: #1591

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

@jcantrill jcantrill Awaiting requested review from jcantrill

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. autoretest Please auto-retest this PR if one of the flaky tests fail backport/completed backport/3.9 backport this PR to release-3.9 backport/3.10 backport/3.11 component/fluentd kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release/4.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dunse @openshift-ci-robot @jcantrill @richm @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot