Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rsyslog_exporter for prometheus #1643

Merged
merged 1 commit into from May 30, 2019

Conversation

richm
Copy link
Contributor

@richm richm commented May 13, 2019

https://jira.coreos.com/browse/LOG-9

This adds the source for the soundcloud rsyslog_exporter
to the rsyslog image and builds it in the Dockerfile.
Requires openshift/cluster-logging-operator#164 to configure it.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 13, 2019
@richm richm added autoretest Please auto-retest this PR if one of the flaky tests fail component/rsyslog issue is related to rsyslog kind/feature Categorizes issue or PR as related to a new feature. release/4.2 labels May 13, 2019
@nhosoi
Copy link
Contributor

nhosoi commented May 13, 2019

/test full-integ-aws

@richm
Copy link
Contributor Author

richm commented May 15, 2019

/retest

@richm richm requested review from bparees and jcantrill May 15, 2019 20:12
@richm
Copy link
Contributor Author

richm commented May 15, 2019

aws flake
/test full-integ-aws

1 similar comment
@richm
Copy link
Contributor Author

richm commented May 16, 2019

aws flake
/test full-integ-aws

@richm
Copy link
Contributor Author

richm commented May 16, 2019

/test full-integ-aws

@nhosoi
Copy link
Contributor

nhosoi commented May 16, 2019

/test full-integ-aws

1 similar comment
@richm
Copy link
Contributor Author

richm commented May 17, 2019

/test full-integ-aws

@richm
Copy link
Contributor Author

richm commented May 21, 2019

/retest

@richm richm force-pushed the rsyslog-prometheus branch 3 times, most recently from ff281c9 to 5f15a9b Compare May 22, 2019 14:04
richm added a commit to richm/cluster-logging-operator that referenced this pull request May 23, 2019
This implements support for the prometheus exporter
provided in the image as part of
openshift/origin-aggregated-logging#1643

This also sets es resources for e2e tests in aws
@richm
Copy link
Contributor Author

richm commented May 23, 2019

/retest

@nhosoi
Copy link
Contributor

nhosoi commented May 23, 2019

/retest

@ewolinetz
Copy link
Contributor

/override continuous-integration/travis-ci/pr

@openshift-ci-robot
Copy link

@ewolinetz: ewolinetz unauthorized: /override is restricted to repo administrators

In response to this:

/override continuous-integration/travis-ci/pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor

/woof

@openshift-ci-robot
Copy link

@ewolinetz: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz closed this May 24, 2019
@ewolinetz ewolinetz reopened this May 24, 2019
@ewolinetz
Copy link
Contributor

/refresh

@nhosoi
Copy link
Contributor

nhosoi commented May 24, 2019

/test full-integ-aws

@nhosoi
Copy link
Contributor

nhosoi commented May 24, 2019

Currently, zzz-rsyslog.sh is failing since rsyslog pod fails to start (or times out). The CLO log shows this error [1] once (this is not an error but just checking if the secret exists or not; if it does not, it generates it) followed by the repeated "Updating status" messages [2] for 10 minutes, then the zzz-rsyslog.sh test times out. This symptom is observed in 2 OAL pr's (another failed pr: #1649), which does not look introduced by them...

[1] time="2019-05-24T21:18:17Z" level=error msg="Unable to read file to get contents: open /tmp/_working_dir/kibana-proxy-oauth.secret: no such file or directory"

[2]
time="2019-05-24T21:18:17Z" level=info msg="Updating status of Kibana for "instance""
time="2019-05-24T21:18:17Z" level=info msg="Updating status of Curator"
time="2019-05-24T21:18:18Z" level=info msg="Updating status of Rsyslog"

This adds the source for the soundcloud rsyslog_exporter
to the rsyslog image and builds it in the Dockerfile.
It doesn't do anything yet - will need cluster-logging-operator
config for that.
@richm
Copy link
Contributor Author

richm commented May 29, 2019

although openshift/cluster-logging-operator#192 has merged, the image is still not available in ci as registry.svc.ci.openshift.org/origin/4.2:cluster-logging-operator - trying to figure out where the image is

@richm
Copy link
Contributor Author

richm commented May 30, 2019

/retest

@richm
Copy link
Contributor Author

richm commented May 30, 2019

finally passed! please review and lgtm

@nhosoi
Copy link
Contributor

nhosoi commented May 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit e2e57d5 into openshift:master May 30, 2019
@richm richm deleted the rsyslog-prometheus branch May 30, 2019 13:46
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
This implements support for the prometheus exporter
provided in the image as part of
openshift/origin-aggregated-logging#1643

This also sets es resources for e2e tests in aws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoretest Please auto-retest this PR if one of the flaky tests fail component/rsyslog issue is related to rsyslog kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release/4.2 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants