Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed upstream component versions #2170

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fixed upstream component versions #2170

merged 1 commit into from
Sep 8, 2021

Conversation

vimalk78
Copy link
Contributor

Description

Fixed upstream component versions to

  • elasticsearch: 6.8.1
  • kibana: 6.8.1
  • fluentd: 1.7.4

/cc @igor-karpukhin @periklis
/assign @jcantrill

Links

periklis
periklis approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@periklis
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
jcantrill
jcantrill reviewed Aug 26, 2021
View reviewed changes
elasticsearch/Dockerfile Show resolved Hide resolved
elasticsearch/Dockerfile
@@ -21,7 +22,7 @@ LABEL \
io.openshift.build.commit.id=${CI_ORIGIN_AGGREGATED_LOGGING_UPSTREAM_COMMIT} \
io.openshift.build.source-location=${CI_ORIGIN_AGGREGATED_LOGGING_UPSTREAM_URL} \
io.openshift.build.commit.url=${CI_ORIGIN_AGGREGATED_LOGGING_UPSTREAM_URL}/commit/${CI_ORIGIN_AGGREGATED_LOGGING_UPSTREAM_COMMIT} \
version=${CI_CONTAINER_VERSION}
version=v6.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of this label? How is it manifested to consumers? Do we need to maybe add in RH or "OpenShift Logging" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this label is used by OSBS to version the image

@vimalk78
Copy link
Contributor Author

/retest

1 similar comment
@periklis
Copy link
Contributor

periklis commented Sep 2, 2021

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@vimalk78
Copy link
Contributor Author

vimalk78 commented Sep 4, 2021

/retest

1 similar comment
@vimalk78
Copy link
Contributor Author

vimalk78 commented Sep 4, 2021

/retest

periklis
periklis suggested changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the changes in curator image.

@vimalk78
Fixed upstream versions
6f6a94b 
    elasticsearch: 6.8.1
    kibana: 6.8.1
    fluentd: 1.7.4
    curator: 5.8.1
periklis
periklis approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@periklis
Copy link
Contributor

periklis commented Sep 8, 2021

/retest

jcantrill
jcantrill reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, periklis, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@jcantrill
Copy link
Contributor

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 097bdcd into openshift:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@periklis periklis periklis approved these changes

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

Assignees

@periklis periklis

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vimalk78 @periklis @jcantrill @openshift-bot @openshift-merge-robot