Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-1494: Added Formatter single_json_value #2175

Merged

Conversation

vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Sep 2, 2021

Description

As part of fix for issue 1494,. this PR adds a new formatter called single_json_value formatter, to be used with syslog plugin.

This formatter is similar to single_value formatter except that it formats the value of the configured key (default value message) in record to json if the value is a Ruby hash. else it formats to a string.

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

@vimalk78
Copy link
Contributor Author

vimalk78 commented Sep 2, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@jcantrill
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@vimalk78
Copy link
Contributor Author

/retest

@vimalk78
Copy link
Contributor Author

/retsst

@vimalk78
Copy link
Contributor Author

/retest

1 similar comment
@vimalk78
Copy link
Contributor Author

/retest

@vimalk78 vimalk78 changed the title LOG-1494: Fix syslog serialization LOG-1494: Added Formetter single_json_value Sep 17, 2021
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vimalk78 vimalk78 changed the title LOG-1494: Added Formetter single_json_value LOG-1494: Added Formatter single_json_value Sep 17, 2021
@vimalk78
Copy link
Contributor Author

/retest

@vimalk78
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2021
@vimalk78
Copy link
Contributor Author

/refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2021

@vimalk78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/clo-functional 43e0b10 link /test clo-functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 28d726e into openshift:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants