Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2002671: Improve logging-dump.sh (backport of LOG-1733 to 3.11) #2177

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Sep 7, 2021

Description

Adding new resources:

Extending curl timout to 20 sec:

We are experiencing empty resource logs in must-gather archives. Instead of expected content they only contain message referencing to "timeout error code (28)".

Completing the documentation.

Adding suffix to each type of resource.

  • .json is a json content (can be directly processed by jq)
  • .cat is output of _cat endpoint (can be processed by awk or sed)
  • .txt is non-structural text format

/cc @btaani
/assign @jcantrill

Links

### Description

Adding new resources:

- Adding [_nodes](https://www.elastic.co/guide/en/elasticsearch/reference/5.6/cluster-nodes-info.html)
- Adding [hot_threads](https://www.elastic.co/guide/en/elasticsearch/reference/5.6/cluster-nodes-hot-threads.html)
- Adding indices_size log

Extending curl timout to 20 sec:

We are experiencing empty resource logs in must-gather archives. Instead of expected content they only contain message referencing to "timeout error code (28)".

Completing the documentation.

Adding suffix to each type of resource.
- .json is a json content (can be directly processed by jq)
- .cat is output of _cat endpoint (can be processed by awk or sed)
- .txt is non-structural text format

/cc @btaani
/assign @periklis

### Links

- JIRA: https://issues.redhat.com/browse/LOG-1734
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@lukas-vlcek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

LOG-1734: Improve logging-dump.sh (backport of LOG-1733 to 3.11)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lukas-vlcek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@lukas-vlcek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

LOG-1734: Improve logging-dump.sh (backport of LOG-1733 to 3.11)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek lukas-vlcek changed the title LOG-1734: Improve logging-dump.sh (backport of LOG-1733 to 3.11) Bug 2002671: Improve logging-dump.sh (backport of LOG-1733 to 3.11) Sep 9, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@lukas-vlcek: This pull request references Bugzilla bug 2002671, which is invalid:

  • expected the bug to target the "3.11.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002671: Improve logging-dump.sh (backport of LOG-1733 to 3.11)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@lukas-vlcek: This pull request references Bugzilla bug 2002671, which is invalid:

  • expected the bug to target the "3.11.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@lukas-vlcek: This pull request references Bugzilla bug 2002671, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@lukas-vlcek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/images ddfb7e7 link /test images
ci/openshift-jenkins/json-file ddfb7e7 link /test json-file
ci/openshift-jenkins/logging ddfb7e7 link /test logging

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Sep 10, 2021

/hold

There seem to be some versioning issues that must be addressed first.
A quick hint from Jeff:

[...] it may because the lock file is not checked in for ruby. same with the python command, we should be able to "lock" what we are building

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021
@jcantrill
Copy link
Contributor

Merging manually as this only changes the logging-dump script for evaluating 3.11 issues.

@jcantrill jcantrill merged commit c31bbac into openshift:release-3.11 Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@lukas-vlcek: All pull requests linked via external trackers have merged:

Bugzilla bug 2002671 has been moved to the MODIFIED state.

In response to this:

Bug 2002671: Improve logging-dump.sh (backport of LOG-1733 to 3.11)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants