Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Fix curator downstream builds with build-isolation #2274

Conversation

periklis
Copy link
Contributor

Description

Required to build curator on ubi9/python-39:1-182.1714671018 because it enables python's build-isolation. When enabled curator brew builds fail to find setuptools (previously when disabled we used the one provided by the system)

/cc @jcantrill

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link

@periklis: This pull request explicitly references no jira issue.

In response to this:

Description

Required to build curator on ubi9/python-39:1-182.1714671018 because it enables python's build-isolation. When enabled curator brew builds fail to find setuptools (previously when disabled we used the one provided by the system)

/cc @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@btaani
Copy link
Member

btaani commented May 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f66ec64 into openshift:master May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants