deployer install: lowercase some variables #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix openshift#224 which notes that several variables are referred to in the install script in uppercase which only works if they were passed in as env vars, not via the configmap. Now the lowercase, mapped versions are used.
|
[test] @ewolinetz PTAL |
|
Evaluated for aggregated logging test up to a5db333 |
|
LGTM |
|
Aggregated Logging Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/787/) |
|
[merge] |
|
Not sure if https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/788/ is a flake? Looks like ES didn't come up but I don't see how my changes made that happen. Try again. [merge] |
|
looks like a build took too long [merge] |
|
Evaluated for aggregated logging merge up to a5db333 |
|
Aggregated Logging Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/790/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #224
which notes that several variables are referred to in the install script
in uppercase which only works if they were passed in as env vars, not
via the configmap. Now the lowercase, mapped versions are used.