Bug 1506099 - fluentd downstream vendor record_modifier #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakjan
added
component/fluentd
kind/bug
openshift-ci-robot
added
the
size/S
wozniakjan
changed the title
wozniakjan
force-pushed
the
bz_1505683/fluentd/record-modifier
branch
from
746a63d
to
1f55de5
Compare
|
/retest |
|
/lgtm |
|
/test json-file |
|
/retest |
|
/test logging |
1 similar comment
|
/test logging |
|
/retest |
1 similar comment
|
/retest |
wozniakjan
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
looks like the failing test is always the same: I would like to take some time and try to find you why, because this PR doesn't change anything in upstream images or tests, only in downstream image and that is not used or built for CI tests AFAIK. Maybe PR #716 will resolve the issue when it merges. |
wozniakjan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Vendoring the missing record_modifier to downstream image. The openshift#622 PR introduced record_modifier to upstream Dockerfile but not to the downstream. openshift#622
wozniakjan
force-pushed
the
bz_1505683/fluentd/record-modifier
branch
from
1f55de5
to
7f6b96e
Compare
openshift-merge-robot
removed
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendoring the missing record_modifier to downstream image. The #622 PR
introduced record_modifier to upstream Dockerfile but not to the downstream.
This is porting forward the #742