Kibana55 #881
Kibana55 #881
Conversation
openshift-ci-robot
added
the
size/XXL
|
@jcantrill: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jcantrill why are we able to remove all those files for kibana as part of this? |
|
@ewolinetz The previous installation of the origin-kibana plugin was vendored in and install was copying all the files into the proper location. They would then be recompiled by us to improve startup. This change vendors in those files as a plugin archive by which we can use the kibana-plugin tool to install which compiles as part of its install process. |
|
|
||
| update_config_from_env_vars() { | ||
| conf_dir=$1 | ||
| kibana_vars=( |
There was a problem hiding this comment.
do we want to let all of these be configured with env vars? e.g. server.host may be alright to keep as 0.0.0.0 in the config... is there a request that we be able to customize this via env vars?
There was a problem hiding this comment.
This is open to debate; I sourced what is here from the script that is used by the Kibana docker image. I know we have an outstanding issue where the request timeout needs to be increased but the work around is complicated. This change would make that easy. I am open to whitelisting the config items to a smaller set.
This PR:
Depends on vendored code from openshift/origin-kibana#27