This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Fix for bug 916323 - #1481
Merged
Fix for bug 916323 - #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making sure that we delete all applications and re-verify before force-deleting a domain
|
There was a potential for an application to be added to a domain while it was in the process of "force-delete". We are now reading from the primary and verifying again before we delete the domain. |
|
[test] |
|
Origin Test Results: SUCCESS (https://originci-openshift.rhcloud.com/job/test_pull_requests/100/) |
|
Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/1103/) |
|
[merge] |
|
Merge Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/1864/) (Image: devenv_2873) |
|
Evaluated up to ed2a45b |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 28, 2013
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making sure that we delete all applications and re-verify
before force-deleting a domain