Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

[WIP] Bug 984867 - Hardcode port 80 for PassengerPreStartUrl #4440

Merged
merged 1 commit into from Jan 10, 2014

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Jan 9, 2014

Due to a change in Passenger code, Passenger is now routing all PreStart requests via 127.0.0.1:

        def connect
                TCPSocket.new('127.0.0.1', request_port)
        end

The 'request_port' is extracted from PassengerPreStartUrl and the HTTP HEAD request is then sent with Host header set to host extracted from URL.

In PROD, where we don't have any HTTP listening on 127.0.0.1:8080, users get this error:

[Thu Jan 09 08:32:25 2014] [notice] Apache/2.2.22 (Unix) Phusion_Passenger/3.0.21 configured -- resuming normal operations
/opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/helper-scripts/prespawn:105:in `initialize': Connection refused - connect(2) (Errno::ECONNREFUSED)
    from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/helper-scripts/prespawn:105:in `new'

However in DEVENV, where we have httpd configured to listen on 127.0.0.1:8080, the request succeded. This patch will hardcode port 80, so the request will succeed in PROD, however we might see the error above on devenv.

@mfojtik
Copy link
Member Author

mfojtik commented Jan 9, 2014

[test]

@openshift-bot
Copy link

@mfojtik
Copy link
Member Author

mfojtik commented Jan 10, 2014

[merge]

@openshift-bot
Copy link

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/4386/) (Image: devenv_4208)

@openshift-bot
Copy link

Evaluated for online up to cba1d7e

openshift-bot pushed a commit that referenced this pull request Jan 10, 2014
@openshift-bot openshift-bot merged commit dc275f9 into openshift:master Jan 10, 2014
@mfojtik mfojtik deleted the bugzilla/984867 branch January 30, 2014 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants