Fix the broken LD_LIBRARY path in cron and move the elements into one common function #4976
Conversation
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/6845/) |
|
@jwhonce @danmcp can you review this one pls? I'm moving the logic around setting the *_PATH from *_PATH_ELEMENT to Bash SDK so the cron and rhcsh will use the same code and having it in one place. The main problem here was that the BASH_SDK var is not exported in cron_runscript which cause the 'get_path_element()' function not be executed.... |
|
@mfojtik It seems wasteful to build both paths and then throw one away, twice. Why not two functions? |
|
@jwhonce you are 100% right, srry about that I spent too much time trying to identify the problem I forgot to refactor the function in the end. Will split it in two. |
|
@jwhonce done :-) |
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/4956/) (Image: devenv_4526) |
|
Evaluated for online up to 3755dfc |
Merged by openshift-bot
No description provided.