Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Bug 1103131: Let users search for global teams they are a member of #5468

Merged
merged 1 commit into from May 30, 2014
Merged

Bug 1103131: Let users search for global teams they are a member of #5468

merged 1 commit into from May 30, 2014

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented May 30, 2014

Remove authorize! check and let Team.accessible() limit which global teams a user can see

@liggitt liggitt changed the title Bug 1103131: Remove authorize! check and let Team.accessible() limit which global teams a user can see Bug 1103131: Let users search for global teams they are a member of May 30, 2014
@liggitt
Copy link
Contributor Author

liggitt commented May 30, 2014

@lnader review

@lnader
Copy link
Contributor

lnader commented May 30, 2014

So with this change everyone can view global teams, right?

@liggitt
Copy link
Contributor Author

liggitt commented May 30, 2014

@lnader if view_global_teams is true, a user can search for any global team. if view_global_teams is false, a user can only search for global teams they are a member of (same as the global teams returned by the index listing). That logic is enforced in Team.accessible().

@lnader
Copy link
Contributor

lnader commented May 30, 2014

Looks good

@liggitt
Copy link
Contributor Author

liggitt commented May 30, 2014

[merge]

@openshift-bot
Copy link

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/5486/) (Image: devenv_4834)

@openshift-bot
Copy link

Evaluated for online up to 1e14237

@openshift-bot
Copy link

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link

@openshift-bot
Copy link

Origin Test Results: SUCCESS (https://50.17.198.52/jenkins/job/test_pull_requests/2412/)

@openshift-bot
Copy link

Evaluated for origin up to 1e14237

openshift-bot pushed a commit that referenced this pull request May 30, 2014
…bal_member_teams

Merged by openshift-bot
@openshift-bot openshift-bot merged commit 6e09bae into openshift:master May 30, 2014
@liggitt liggitt deleted the bug_1103131_allow_searching_global_member_teams branch June 3, 2014 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants