This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
oo-iptables-port-proxy: getaddr: clean-up and add check #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the getaddr command to use pure Bash with only one fork and simpler (and hopefully more reliable) parsing.
Check that ipaddr is not empty in getaddr and report a helpful error message if it is. This commit fixes bug 1121200.
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/7965/) |
|
Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/2634/) |
|
Evaluated for origin up to a9b1438 |
|
LGTM |
|
Thanks! [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/5759/) (Image: devenv_5027) |
|
Evaluated for online up to a9b1438 |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 29, 2014
…xy-getaddr-check-ipaddr Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the
getaddrcommand to use pure Bash with only one fork and simpler (and hopefully more reliable) parsing.Check that the IP address is not empty in
getaddrand report a helpful error message if it is.This commit fixes bug 1121200.