This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
BZ1158704 - Broker fails to create HA DNS entry for HA app #5956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
calfonso
commented
Nov 12, 2014
calfonso
commented
- If the ha parameter is passed as part of the application creation api,
- the broker was not adding the pending operation to create the routing
- dns. After adding this patch, the routing DNS record is created if and
- only if the broker.conf is set to manage the external routing DNS.
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6175/) (Image: devenv_5298) |
* If the ha parameter is passed as part of the application creation api, * the broker was not adding the pending operation to create the routing * dns. After adding this patch, the routing DNS record is created if and * only if the broker.conf is set to manage the external routing DNS.
|
[merge] |
|
Evaluated for online up to d15a9d2 |
openshift-bot
pushed a commit
that referenced
this pull request
Nov 12, 2014
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.