This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug 1165719 - oo-accept-node incorrectly using manifests from cart repository #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pository - oo-accept-node should use the manifest from the installed cartridge instead of from the cartridge repository, otherwise downloadable carts are not verified.
|
@bparees Review please. |
|
the change looks ok, but do we really want this in before stagecut this release? |
|
@bparees I wasn't pushing to get it before stage cut. I was just going through the origin-server pulls in general. |
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6274/) |
|
Evaluated for online up to 400a9f4 |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 17, 2015
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of from the cartridge repository, otherwise downloadable
carts are not verified.