Node: create tuned-profiles-openshift-node #6024
Conversation
|
[test] to verify the package builds properly via jenkins, it built fine by hand |
|
@maxamillion mind reviewing this PR? |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8592/) |
|
Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3232/) |
| @@ -282,6 +287,29 @@ fi | |||
| %attr(0755,-,-) /etc/cron.monthly/openshift-origin-cron-monthly | |||
| %attr(0755,-,-) /etc/cron.daily/openshift-origin-stale-lockfiles | |||
|
|
|||
| ################## start tuned-profiles-openshift-node ############### | |||
| %package -n tuned-profiles-openshift-node | |||
There was a problem hiding this comment.
I'm curious what the motivation of making this a subpackage instead of it's own package was?
There was a problem hiding this comment.
I wanted it associated with the node directory tree and it seemed odd to create a spec file in a subdirectory of a directory that already had a spec file. Tito may have some hangups with it as well.
The other option I can see is moving tune-profiles into the root of the repo. If we were to create profiles for other roles that would probably make the most sense. However, I foresee no need for additional profiles at this time.
There was a problem hiding this comment.
My biggest worry with it being a subpackage is that this is technically a rubygem package and it should (which it doesn't currently because it needs updating) have Source0 as a .gem file and not a .tar.gz[0] where as the tuned-profiles don't have any real association with the rubygems.
I'm open to suggestion though, but it seems odd at face value.
@tdawson - any thoughts?
sdodson
force-pushed
the
tuned-profile
branch
2 times, most recently
from
0073ff8
to
9a96406
Compare
Bug 889539 - [RFE] create tuned profile for openshift-enterprise nodes This adds an optional subpackage named 'tuned-profiles-openshift-node' which contains a tuned profile suitable for OpenShift Node hosts. When installed this RPM will enable the profile starting tuned if it's not currently running.
|
[test] i'd like to see jenkins build the rpm |
|
@maxamillion How do I get jenkins to build a new package? It says it's skipping it because it's not tagged. I've created a tag for it on my forked branch but I cannot push tags to origin-server. From https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3228/consoleFull -> 'Skipping 'tuned-profiles-openshift-node' in '/data/src/github.com/openshift/origin-server/tune-profiles/openshift-node' since it is not tagged.' |
|
Needs a |
|
Correction, I see tito commits in the changelog ... let me dig in, something doesn't look right. |
|
Alright, so yes and no on the tito thing. Tito should have created a git tag, can you run a |
|
You're right, looks like I failed to push the tag to my fork, sorry about that. [test] again |
|
Evaluated for origin up to 63105e4 |
|
@maxamillion Looks like it's built successfully now, you ok with merging this as it is now? |
|
[merge] 👍 |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6251/) (Image: devenv_5379) |
|
[merge] the failure looked like jenkins just puked |
|
Evaluated for online up to 63105e4 |
Bug 889539 - [RFE] create tuned profile for openshift-enterprise nodes
This adds an optional subpackage named 'tuned-profiles-openshift-node' which
contains a tuned profile suitable for OpenShift Node hosts. When installed this
RPM will enable the profile starting tuned if it's not currently running.