This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug1176491: pass the pear channel-update with error due to the internet access problem #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nak3
changed the title
| @@ -35,6 +35,6 @@ rm -f $OPENSHIFT_HOMEDIR/.pearrc | |||
| php_context "pear config-create ${OPENSHIFT_PHP_DIR}phplib/pear/ ${OPENSHIFT_HOMEDIR}.pearrc" | |||
| php_context "pear -c ${OPENSHIFT_HOMEDIR}.pearrc config-set php_ini ${OPENSHIFT_PHP_DIR}configuration/etc/php.ini" | |||
| php_context "pear -c ${OPENSHIFT_HOMEDIR}.pearrc config-set auto_discover 1" | |||
| php_context "pear -c ${OPENSHIFT_HOMEDIR}.pearrc channel-update pear.php.net" | |||
| php_context "pear -c ${OPENSHIFT_HOMEDIR}.pearrc channel-update pear.php.net" && true | |||
There was a problem hiding this comment.
I think you want || true as the && will short circuit. Otherwise, agree this is a decent approach - try to improve the situation if possible, but let the install continue (with warnings printed) if not.
There was a problem hiding this comment.
&& true is also short circuit, although || true is more understandable.
$ cat foo.sh
#!/bin/bash -eu
false && true
echo "foo"
$ ./foo.sh
foo
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6241/) (Image: devenv_5373) |
|
Evaluated for online up to cf008eb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also bz1176491
The root cause of bz1176491 is that the script bash sets "-e" option.
So, putting "&& true" like below will be able to fix it.
I know it is better if showing warning messages if the channel-update didn't work out. However, to output such a message needs several change in the other components more than openshift-origin-cartridge-php/bin/install.
So I think putting "&& true" is OK for this issue.