Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

BZ1199901, BZ1199903, BZ1199904 creating and deleting monitors #6092

Merged
merged 1 commit into from Mar 13, 2015

Conversation

calfonso
Copy link
Contributor

No description provided.

@@ -32,7 +32,7 @@ HTTP_PORT=80
#MONITOR_NAME=monitor_ose_%a_%n
#MONITOR_PATH=/health_check.php
#MONITOR_UP_CODE=1
MONITOR_TYPE=http-ecv
MONITOR_TYPE=http
#MONITOR_TYPE=https-ecv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well delete -ecv here too.

@Miciah
Copy link
Contributor

Miciah commented Mar 11, 2015

Don't hate me, but I wonder whether it would be better not to add the type parameter everywhere and pass the type from daemon.rb, but rather to have the models read the type parameter from the configuration file. Is monitor type an implementation detail of the load balancers, or is it something the daemon really should know about?

@calfonso calfonso force-pushed the bz1199901 branch 3 times, most recently from bfa6f65 to 3812a31 Compare March 11, 2015 18:55
@calfonso
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link

Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6331/) (Image: devenv_5467)

@openshift-bot
Copy link

Evaluated for online up to 42f5081

@openshift-bot
Copy link

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link

openshift-bot pushed a commit that referenced this pull request Mar 13, 2015
@openshift-bot openshift-bot merged commit 382c49a into openshift:master Mar 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants