This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Change the priority number for openshift-tc #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IshentRas
commented
May 18, 2015
IshentRas
commented
- Change the priority number to be higher than the network interfaces ( number 10).
- Causing issues (File : node/lib/openshift-origin-node/utils/tc.rb:105) when using bonding interfaces (bondx) as EXTERNAL_ETH_DEV as the MTU is not actually predefined before the start.
|
[test] |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8744/) |
|
We should probably also have openshift-tc stop before network stops. Network has a stop priority of 90, so a stop priority of 89 on openshift-tc should be perfect. |
|
I agree with you +1, I am going to modify this. |
|
[test] |
|
@brenton this is ready to merge in my opinion. |
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6392/) (Image: devenv_5524) |
|
Evaluated for online up to 8fc6f7f |
openshift-bot
pushed a commit
that referenced
this pull request
May 20, 2015
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.