This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Round up if base filesystem quota is less than 1Gb #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Online Test Results: FAILURE (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8818/) |
|
[test] again |
|
@danmcp could you review this? |
| quota_blocks / 1024 / 1024 | ||
| else | ||
| 1 | ||
| end |
There was a problem hiding this comment.
How about [quota_blocks / 1048576, 1].max
Bug 1197123 https://bugzilla.redhat.com/show_bug.cgi?id=1197123 When a node profile specifies a 'quota_blocks' value less than 1Gb (1048576), round up to 1Gb rather than returning 0. This will inaccurately report base storage as 1Gb when it may be much less, but will avoid reporting that a gear has 0 base storage.
|
@danmcp this should be ready now, thanks for the recommendation! |
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6468/) (Image: devenv_5584) |
|
Evaluated for online up to a4b1b07 |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 13, 2015
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1197123
https://bugzilla.redhat.com/show_bug.cgi?id=1197123
When a node profile specifies a 'quota_blocks' value less than 1Gb (1048576), round up to 1Gb rather than returning 0. This will inaccurately report base storage as 1Gb when it may be much less, but will avoid reporting that a gear has 0 base storage.