This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Fixing short-form optparse options #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 1311730 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1311730 Errors were being seen when command line tools using the 'optparse' libary. Using long-form only options with a single dash was resulting in odd returns, but no errors. This is because optparse automatically infers a short-form option for long-form options that have a unique starting letter. So '--ids' has an implied short-form of '-i'. This meant that running a command with '-ids' would actually use '-i' and pass in "ds" as an ID value. This commit takes several cases where this happens and explicitely defines the short-form options in the relevant scripts and man pages, which should reduce confusion on why certain options may not error out as expected. Also updates an old man page to reflect the current options.
|
LGTM Since we don't have any automated tests that cover these scripts (and most of your changes just result in help page changes), I tested these myself. Did not find any problem with the modified admin scripts and saw the options in the help pages where expected. [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6733/) (Image: devenv_5794) |
|
Evaluated for online merge up to 3b5dcf0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1311730
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1311730
Errors were being seen when command line tools using the 'optparse' libary.
Using long-form only options with a single dash was resulting in odd returns,
but no errors. This is because optparse automatically infers a short-form
option for long-form options that have a unique starting letter. So '--ids' has
an implied short-form of '-i'. This meant that running a command with '-ids'
would actually use '-i' and pass in "ds" as an ID value. This commit takes
several cases where this happens and explicitely defines the short-form options
in the relevant scripts and man pages, which should reduce confusion on why
certain options may not error out as expected.
Also updates an old man page to reflect the current options.