This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
routing-daemon: F5: Rescue more network errors #6407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miciah
force-pushed
the
bug-1227472-routing-daemon-f5-rescue-more-network-errors
branch
from
326caa0
to
410d468
Compare
F5IControlRestLoadBalancerModel#rest_request: Rescue several additional exceptions that failure to connect to the F5 BIG-IP host can raise, and attempt retries for these exceptions. Newer versions of the restclient gem should wrap these exceptions, but there has been at least one report where restclient let through an unwrapped exception (Errno::ETIMEDOUT), and as a result, F5IControlRestLoadBalancerModel#rest_request did not rescue the exception and thus did not follow the retry logic. This commit is related to commit f9d4782. This commit is related to bug 1227472. https://bugzilla.redhat.com/show_bug.cgi?id=1227472
Miciah
force-pushed
the
bug-1227472-routing-daemon-f5-rescue-more-network-errors
branch
from
410d468
to
dc1be12
Compare
|
I don't see any issues with this approach. LGTM |
|
We don't have any tests that test the routing daemon at all, right? |
|
Thanks! That's right. 😢 |
|
Well then lets go ahead and [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9345/) (Image: devenv_5807) |
|
Evaluated for online merge up to dc1be12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F5IControlRestLoadBalancerModel#rest_request: Rescue several additional exceptions that failure to connect to the F5 BIG-IP host can raise, and attempt retries for these exceptions.Newer versions of the restclient gem should wrap these exceptions, but there has been at least one report where restclient let through an unwrapped exception (
Errno::ETIMEDOUT), and as a result,F5IControlRestLoadBalancerModel#rest_requestdid not rescue the exception and thus did not follow the retry logic.This commit is related to commit f9d4782.
This commit is related to bug 1227472.
https://bugzilla.redhat.com/show_bug.cgi?id=1227472