Don't select a default project if there is more than one project

[dtaylor113]

The following changes have been made to the <select-project> component:

• Accepts a list of projects, so another projects retrieval is not needed (performant)
• Callback method when project selected.
• Does not select a project by default, unless there is only one project
• required asterisk, error msg if user clicks on dropdown, but doesn't select a project
• Sorts projects by displayName

No Project Selected

User clicks on then off dropdown, and doesn't select a project:

Project Selected

Fixes: openshift/origin-web-console#1833

[spadgett]

We should have class="required" on the label so it gets the asterisk.

We shouldn't show the red error text when the page first loads. Only if the user focuses the project select, but doesn't select anything.

[dtaylor113]

@spadgett added required and error text when no project selected after losing focus.

[serenamarie125]

@spadgett curious on "Sorts projects by displayName" . Should we enhance this to sort primary by last accessed by the user & secondary by displayName?

@dtaylor113 also curious if this is ui-select if we are including the search capability here?

[dtaylor113]

@dtaylor113 also curious if this is ui-select if we are including the search capability here?

Yup :-)

[spadgett]

@spadgett curious on "Sorts projects by displayName" . Should we enhance this to sort primary by last accessed by the user & secondary by displayName?

Yeah, I think so. It's also possible to group items in ui-select, so we could have "Recent" and "All" groups if we want.

[spadgett]

removed unused name-taken attribute

@dtaylor113 name-taken is being used

https://github.com/openshift/origin-web-console/search?utf8=%E2%9C%93&q=name-taken&type=

[spadgett]

We should add back name-taken and make sure it's being used properly by callers.

[spadgett]

Probably should handle changes to the passed-in projects.

[dtaylor113]

Fixed

[spadgett]

There's for="project", but I don't see an id="project" anywhere. Not new, but we should fix.

If we use an ID here, let's pick a more specific name that is less likely to conflict with another ID that happens to be on the page. It might be easiest just to remove that for now because I'm not sure how to set the ID of the input with ui-select.

[dtaylor113]

Ok, removed for="project"

[dtaylor113]

@dtaylor113 name-taken is being used

I see that the HTML is using projectNameTaken, but I don't see that variable being used/set in any of the controllers. I think it needs to be removed from the HTML.

[spadgett]

name-taken was replaced by osc-unique and wasn't being used anywhere

No, it can't be replaced by osc-unique. Normal users can't see all projects in the cluster, so you don't have a complete list of project names. We still need to handle errors from the server creating the project because the name is already in use by someone else.

We need to add name-taken back and make sure it's used properly everywhere. It's a bug if it was removed from any of the controllers.

[spadgett]

To be clear, we should still use osc-unique so we can warn users earlier when we know a project name already exists. But we also have to handle the case where we only find out later when we try to create the project.

[dtaylor113]

We need to add name-taken back and make sure it's used properly everywhere. It's a bug if it was removed from any of the controllers.

Hi @spadgett, ok added back name-taken and filed this issue: openshift/origin-web-console#1955

[spadgett]

Thanks @dtaylor113 LGTM