Support bind parameters #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
bind-parameters
branch
2 times, most recently
from
a92a921
to
5a865ac
Compare
spadgett
force-pushed
the
bind-parameters
branch
from
5a865ac
to
c20f393
Compare
jeff-phillips-18
approved these changes
Sep 1, 2017
| this.bindParametersStep.hidden = this.bindStep.hidden || | ||
| this.ctrl.bindType === 'none' || | ||
| !_.has(this.ctrl, 'bindParameterSchema.properties'); | ||
| this.bindParametersStep.allowed = !this.bindParametersStep.hidden && this.bindStep.valid; |
There was a problem hiding this comment.
nit: don't really need to check hidden here, if it is hidden then allowed will never be used.
| @@ -174,7 +196,17 @@ export class OrderServiceController implements angular.IController { | |||
|
|
|||
| this.validityWatcher = this.$scope.$watch("$ctrl.forms.bindForm.$valid", (isValid: any, lastValue: any) => { | |||
| this.bindStep.valid = isValid; | |||
| this.reviewStep.allowed = this.bindStep.valid; | |||
| this.bindParametersStep.allowed = !this.bindParametersStep.hidden && isValid; | |||
There was a problem hiding this comment.
nit: don't really need to check hidden here, if it is hidden then allowed will never be used.
spadgett
force-pushed
the
bind-parameters
branch
from
c20f393
to
5331a83
Compare
dtaylor113
approved these changes
Sep 6, 2017
|
Needs a common bump :( |
|
Sorry I shouldn't have removed WIP without the common release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Sws4p5jU
Requires openshift/origin-web-common#163
See also openshift/origin-web-console#1987
@jeff-phillips-18 FYI