Adopt more service catalog API changes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
spadgett
changed the title
app/mockServices/mockAPI.service.ts
Outdated
| clusterserviceclasses: {group: 'servicecatalog.k8s.io', resource: 'serviceclasses' }, | ||
| clusterserviceplans: {group: 'servicecatalog.k8s.io', resource: 'serviceplans' }, | ||
| clusterserviceclasses: {group: 'servicecatalog.k8s.io', resource: 'clusterserviceclasses' }, | ||
| clusterserviceplans: {group: 'servicecatalog.k8s.io', resource: 'clusterserviceplans' }, | ||
| imagestreams: {group: 'image.openshift.io', version: 'v1', resource: 'imagestreams' }, | ||
| // Using the anticipated name for this resource, even though it's not currently called servicebindings. | ||
| servicebindings: {group: 'servicecatalog.k8s.io', resource: 'serviceinstancecredentials' }, |
There was a problem hiding this comment.
resource value should be 'servicebindings'
spadgett
force-pushed
the
catalog-api-changes
branch
from
ff571c2
to
962858a
Compare
|
LGTM |
spadgett
force-pushed
the
catalog-api-changes
branch
2 times, most recently
from
3003710
to
f4d5a30
Compare
spadgett
changed the title
spadgett
force-pushed
the
catalog-api-changes
branch
3 times, most recently
from
78986f8
to
6203027
Compare
Bumps origin-web-common to 0.0.66 * Cluster prefix for service classes and plans * ServiceInstanceCredential -> ServiceBinding * check removedFromBrokerCatalog
spadgett
force-pushed
the
catalog-api-changes
branch
from
6203027
to
da8ccf6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires openshift/origin-web-common#223
Updates origin-web-common to 0.0.66
TODO:
cc @jeff-phillips-18