Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate when exact character count results in ellipsis and "See All" even though there is nothing more #98

Closed
rhamilto opened this issue Jun 8, 2017 · 6 comments
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3

Comments

@rhamilto
Copy link
Member

rhamilto commented Jun 8, 2017

Character count is exact match for truncate, so . is removed, ... and See All is added.
screen shot 2017-06-08 at 9 37 38 am

Clicking "See All" restores the .
screen shot 2017-06-08 at 9 37 43 am

@rhamilto rhamilto added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Jun 8, 2017
@rhamilto rhamilto added this to the 3.6.0 milestone Jun 8, 2017
@rhamilto rhamilto changed the title truncate when exact character count results in ellipsis and See more even though there is nothing more truncate when exact character count results in ellipsis and "See All" even though there is nothing more Jun 8, 2017
@spadgett spadgett assigned cdcabrera and unassigned spadgett Jun 13, 2017
@spadgett
Copy link
Member

Reopening as I don't believe this particular problem is fixed even though other truncate bugs are fixed.

@spadgett spadgett reopened this Jul 31, 2017
@cdcabrera
Copy link
Contributor

@spadgett as a possible solution to helping close this issue down, what's the take on implementing a unit test around toast notifications within this repository?

@spadgett spadgett removed this from the 3.6.0 milestone Nov 2, 2017
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 14, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3
Projects
None yet
Development

No branches or pull requests

5 participants