Fix runtime error in service group watch when service undefined

openshift · Jun 17, 2016 · d904e41 · d904e41
1 parent 498b2be
commit d904e41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/scripts/directives/overview/serviceGroup.js b/app/scripts/directives/overview/serviceGroup.js
@@ -65,6 +65,9 @@ angular.module('openshiftConsole')
         });
 
         $scope.$watchGroup(['service', 'childServicesByParent'], function() {
+          if (!$scope.service) {
+            return;
+          }
           $scope.childServices = _.get($scope, ['childServicesByParent', $scope.service.metadata.name], []);
           $scope.groupedServices = [$scope.service].concat($scope.childServices);
         });

diff --git a/dist/scripts/scripts.js b/dist/scripts/scripts.js
@@ -7946,7 +7946,7 @@ _.each(a, function(a) {
 return b ? void (b = c.getPreferredDisplayRoute(b, a)) :void (b = a);
 }), e.displayRoute = b;
 }), e.$watchGroup([ "service", "childServicesByParent" ], function() {
-e.childServices = _.get(e, [ "childServicesByParent", e.service.metadata.name ], []), e.groupedServices = [ e.service ].concat(e.childServices);
+e.service && (e.childServices = _.get(e, [ "childServicesByParent", e.service.metadata.name ], []), e.groupedServices = [ e.service ].concat(e.childServices));
 });
 }
 };