Fixing bug where creating from a template file was busted #1007
Conversation
| @@ -118,6 +118,7 @@ angular.module("openshiftConsole") | |||
| return; | |||
| } | |||
|
|
|||
| $scope.resource = resource; | |||
There was a problem hiding this comment.
so it doesn't need to be on the scope unless the view is using it, just needs to be stored as a local var for the controller
| @@ -118,6 +118,7 @@ angular.module("openshiftConsole") | |||
| return; | |||
| } | |||
|
|
|||
| $scope.resource = resource; | |||
There was a problem hiding this comment.
Shouldn't need to set this as a scope var, can just use resource below when you call createFromTemplateURL below
There was a problem hiding this comment.
Resource is scoped to only this function. How do I get it out of this function?
|
@rhamilto can you sweep the code for other places where this might be a problem (templates or image streams) |
|
[merge] |
|
Evaluated for origin web console merge up to 4809bf6 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/826/) (Base Commit: b959663) |
Fixes #1005
@benjaminapetersen, @spadgett, @jwforres, PTAL