Fixes "wobble" or "jitter" of spinning .status-icons #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Dec 9, 2016
| // line-height: normal fixes the wobble (see https://github.com/FortAwesome/Font-Awesome/issues/671#issuecomment-249591495 ) | ||
| // margin-right puts a bit of space between the icon and the text that follows, which is necessary given the larger icon size | ||
| .status-icon > .fa-spin { | ||
| font-size: 14px; |
There was a problem hiding this comment.
any reason not to make all the status icons 14px? not just when fa-spin is there
There was a problem hiding this comment.
Yeah. It turns out we're using status-icons at several different font sizes depending on the context, so making all status-icons 14px creates several new bugs. Scoping this to only .fa-spin fixes this issue, but doesn't create new ones.
Additionally, I've opened a new issue to address some of the inconsistencies with status-icons I discovered when investigating.
was most noticeable in Firefox for Linux Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365301
jwforres
approved these changes
Dec 13, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 3f02643 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/850/) (Base Commit: 43e511f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was most noticeable in Firefox for Linux
Before: http://recordit.co/NzMKf14SW5
After: http://recordit.co/IYypdfreyn
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365301
@jwforres or @spadgett, PTAL