Preserve line breaks in project descriptions #1017
Conversation
Resolves #12194
|
so in other places we chose not to show all text when highlighting because it made things jump around |
|
The show all text when highlighting is not a change to this PR. The existing word limit was/is 1000 characters. So I assumed that since we're already showing a max of 1000 characters (which seems like a whole lotta characters for a description), we probably don't won't to limit the line breaks, either. Otherwise, you could end up with a situation where the highlighting isn't visible. Yea/nay? |
|
ah k thats fine then, maybe i misremembered the result of our previous discussion on showing more when filtering. |
|
[merge] |
|
Evaluated for origin web console merge up to 3182c70 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/839/) (Base Commit: 8f964a8) |
Resolves openshift/origin#12194
Limits line breaks to 10 for the truncated display (does not apply to the highlighted text display). Also adds word-break for long, unbroken strings so they do not break the layout.
@jwforres or @spadgett, PTAL