Show CPU usage as cores rather than millicores #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
metrics-cpu-cores
branch
from
6f4c99c
to
9e27779
Compare
spadgett
commented
Dec 12, 2016
| tick: { | ||
| format: function(value) { | ||
| return d3.round(value, 3); | ||
| } |
There was a problem hiding this comment.
Since we're letting c3.js pick the tick values, this is no longer necessary. c3.js picks round numbers. It can also cause problems for very low CPU usage where a tick is repeated.
spadgett
force-pushed
the
metrics-cpu-cores
branch
from
9e27779
to
ed4e563
Compare
jwforres
approved these changes
Dec 12, 2016
|
[merge] |
|
Evaluated for origin web console merge up to ed4e563 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/840/) (Base Commit: 3e63c9c) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cores is a more universally understood unit than millicores.
Related to openshift/origin#7768