Bug 1404079 - Show build reason consistently when the build is in any phase except Cancelled #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… phase except Cancelled
jwforres
force-pushed
the
build-reason-new
branch
from
e648302
to
853a144
Compare
|
@spadgett it behaved inconsistently between the pages, some places were only showing it for Failed whereas others were just preventing it for Cancelled, made it consistent with the latter since the reasons that can show up for New are useful for debugging why the build isnt starting. |
spadgett
approved these changes
Dec 13, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 853a144 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/844/) (Base Commit: cbbfb2e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1404079