Add link to deployment and dc from pod page #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pod is part of a deployment, add a link to the deployment and deployment config.
|
For reference, here's the link on the replication controller page:
|
jwforres
reviewed
Dec 15, 2016
| var podResolved = function(pod, action) { | ||
| $scope.loaded = true; | ||
| $scope.pod = pod; | ||
| $scope.dcName = annotation(pod, 'deploymentConfig'); | ||
| $scope.rcName = annotation(pod, 'deployment'); | ||
| $scope.deploymentVersion = annotation(pod, 'deploymentVersion'); |
There was a problem hiding this comment.
don't we want the same for pods that are part of other controllers? or are we waiting for the rebase to get pods with ownerRefs
There was a problem hiding this comment.
or are we waiting for the rebase to get pods with ownerRefs
Yes, waiting for owner refs. I don't see any way to do this for other controllers yet.
jwforres
approved these changes
Dec 15, 2016
|
[merge] |
[merge] |
|
[merge] AWS capacity issue
…On Thu, Dec 15, 2016 at 9:55 AM, OpenShift Bot ***@***.***> wrote:
Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.
com/jenkins/job/test_pull_requests_origin_web_console/858/) (Base Commit:
8e40552
<8e40552>
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1041 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7drK-W4AykXNSZnAy6YLRjRzQ0zOks5rIVTMgaJpZM4LNYGj>
.
|
|
[merge] |
|
Evaluated for origin web console merge up to 2dc6b92 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/862/) (Base Commit: 247492a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pod is part of a deployment, add a link to the deployment and deployment config.
Closes #319
Replaces #1039