Make tabs work with one tap on iOS #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the a:hover:before pseudo-class on tabs so that iOS doesn't treat the first tap as a hover.
jwforres
reviewed
Dec 19, 2016
| // Add a class for iOS devices. This lets us disable some hover effects | ||
| // since iOS will treat the first tap as a hover if it changes the DOM | ||
| // content (e.g. using :before pseudo-elements). | ||
| $('body').addClass('ios'); |
|
otherwise LGTM |
jwforres
approved these changes
Dec 19, 2016
|
k works for me [merge] |
|
Evaluated for origin web console merge up to e132668 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/872/) (Base Commit: 7973c2b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
a:hover:beforepseudo-class on tabs so that iOS doesn't treat the first tap as a hover.Fixes #811