Improve Git URL error messages #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you tabbed through the Git URL field without setting a value, it would highlight the input orange without any text explaining. Change it to NOT highlight the field until the user types something. If the user types something and removes it, highlight the field red and show a required field error. This is consistent with other forms like "New Project" and the "Name" field just above Git repository on the "Add to Project" page. Also add a missing required field message to the build config editor if you remove the Git URL.
|
LGTM, tested & works well! |
benjaminapetersen
approved these changes
Dec 21, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 4d2774b |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/878/) (Base Commit: 171a067) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you tabbed through the Git URL field without setting a
value, it would highlight the input orange without any text explaining.
Change it to NOT highlight the field until the user types something. If
the user types something and removes it, highlight the field red and
show a required field error. This is consistent with other forms like
"New Project" and the "Name" field just above Git repository on the "Add
to Project" page.
Also add a missing required field message to the build config editor if
you remove the Git URL.