Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds not showing up in builds table #1067

Merged
merged 1 commit into from
Dec 22, 2016

Conversation

spadgett
Copy link
Member

Fixes this problem:

screen shot 2016-12-21 at 3 54 12 pm

Also fixes some problems introduced when an additional duration column was added.

Relate to #1045

@benjaminapetersen
Copy link
Contributor

Nice, this is fixed here:
screen shot 2016-12-22 at 9 54 33 am
screen shot 2016-12-22 at 9 54 57 am

@spadgett
Copy link
Member Author

Yeah we added a column and forgot to change the empty message colspan.

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spadgett
Copy link
Member Author

thanks @benjaminapetersen

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to d502c1e

@openshift-bot
Copy link

openshift-bot commented Dec 22, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/883/) (Base Commit: 4e95180)

@openshift-bot openshift-bot merged commit ab61c6f into openshift:master Dec 22, 2016
@spadgett spadgett deleted the fix-builds-table branch December 22, 2016 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants