Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent mobile table td collapsing issue #1131

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Prevent mobile table td collapsing issue #1131

merged 1 commit into from
Jan 18, 2017

Conversation

sg00dwin
Copy link
Member

Fixes #1128

screen shot 2017-01-17 at 4 44 41 pm

@spadgett
Copy link
Member

In other places, we used a non-breaking space to make sure the table cell had height. For instance,

https://github.com/spadgett/origin-web-console/blob/695c74dc0fac848444c79c555fb689c4d8431973/app/views/browse/routes.html#L82

If we have a different solution, we should probably change those to be consistent.

spadgett
spadgett reviewed Jan 18, 2017
View reviewed changes
app/styles/_tables.less
@@ -123,6 +123,7 @@
/* Behave like a row */
border: none;
border-bottom: 1px solid lighten(@table-border-color, 5%);
min-height: 38px; // prevent empty td collapsing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a magic number. Is there any existing variable that makes sense for min-height?

@spadgett
Copy link
Member

cc @rhamilto

@sg00dwin
Copy link
Member Author

Updated PR, switched to using non-breaking space to maintain td height

rhamilto
rhamilto reviewed Jan 18, 2017
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the non-breaking space is a dirty hack that will only fix this one instance.

I much prefer the CSS approach you took earlier. Rather than setting an absolute value of 38px, can't you calculate that value by summing variables?

@spadgett
Copy link
Member

I'm good with the CSS fix. Just saying we should remove the nbsp in other places if it's no longer needed to clean up our markup.

@sg00dwin
Copy link
Member Author

Updated pr to use min-height calculated.

Note: related issue pertaining to switching out other   used to give height, will be corrected in other pr.

@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 5e1aa62

@openshift-bot
Copy link

openshift-bot commented Jan 18, 2017 •
edited

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/931/) (Base Commit: 2d9fec8)

@openshift-bot openshift-bot merged commit f3d64d5 into openshift:master Jan 18, 2017
@sg00dwin sg00dwin deleted the empty-td-mobile-issue1128 branch January 18, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@spadgett spadgett spadgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sg00dwin @spadgett @openshift-bot @rhamilto