Create storage form improvements #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly show error messages for invalid capacity values * Make GiB the default unit * Remove PiB unit since it's unlikely to be needed * Add decimal units in addition to current binary units (to be consistent with set limits page) * Add units help modal * Group units in the ui-select (for both create storage and set limits)
|
@jwforres I plan to add the limit range check in a follow-on. |
jwforres
approved these changes
Jan 18, 2017
|
awesome thanks for fixing these [merge] |
|
Evaluated for origin web console merge up to 37d1499 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/928/) (Base Commit: c421188) |
|
Limit range validation added in #1134. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erinboyd @zherman0 fyi