Support filtering provisioned services on overview

[spadgett]

[spadgett]

@jwforres LabelSelector.select() rejects objects with no labels even when there are no active filters. Is this a label selector bug?

[jwforres]

Not a bug, it's an option when you instantiate the LabelSelector. There are times when we want empty to select all (when being used as a filter) and times where we want empty to select nothing. Conceptually this would be like a Service with no selector set wouldn't select any Pods.

…

On Apr 19, 2017 8:32 AM, "Sam Padgett" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/scripts/controllers/newOverview.js <#1444 (comment)> : > @@ -301,11 +301,15 @@ function OverviewController($scope, }; var filterByLabel = function(items) { - return LabelFilter.getLabelSelector().select(items); + var labelSelector = LabelFilter.getLabelSelector(); + if (labelSelector.isEmpty()) { + return items; + } @jwforres <https://github.com/jwforres> The label LabelSelector.select() rejects objects with no labels even when there are no active filters. Is this a label selector bug? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1444 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZk7WQeompvW8sirl3nPAUmsyvR76jjks5rxf7igaJpZM4NBnKI> .

[spadgett]

Requires kubernetes-ui/label-selector#31

[spadgett]

@jwforres updated

[jwforres]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to 143a0ff

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1254/) (Base Commit: 75d1c56)

[benjaminapetersen]

Touch behind on this since its already merging but looks good to me :)