Allow the user to select containers when adding a secret to an application #2058
Conversation
There was a problem hiding this comment.
@jeff-phillips-18 Looks good. I think we should let users pick containers for env variables, too.
| @@ -69,6 +69,23 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div ng-if="ctrl.addType === 'volume' && ctrl.application.spec.template.spec.containers.length > 1" class="volume-options"> | |||
There was a problem hiding this comment.
We should go ahead do the same for environment variables as well I think
| <a href="" ng-click="ctrl.attachAllContainers = false">select specific containers</a> | ||
| instead. | ||
| </div> | ||
| <div ng-if="!ctrl.attachAllContainers" class="form-group"> |
There was a problem hiding this comment.
@jeff-phillips-18 Is there a max-height on the dialog in case there are a lot of containers?
There was a problem hiding this comment.
nope, I suppose there ought to be. Thanks!
There was a problem hiding this comment.
Set the max height on the list of containers.
jeff-phillips-18
force-pushed
the
containers
branch
from
baef910
to
8a4bef2
Compare
|
Updates to allow container selection for both Environment Variables and Volume
with scrolling containers:
|
|
[merge][severity: bug] |
1 similar comment
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to 8a4bef2 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/186/) (Base Commit: b947915) (PR Branch Commit: 8a4bef2) (Extended Tests: bug) |
Fixes #2024