Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure project bar always appears on page load #2064

Merged
merged 1 commit into from Sep 13, 2017
Merged

Make sure project bar always appears on page load #2064

merged 1 commit into from Sep 13, 2017

Conversation

spadgett
Copy link
Member

Closes #2016

@spadgett
Copy link
Member Author

@benjaminapetersen Based on my test PR #2062, I believe $onRouteChangeSuccess is not always getting called on initial page load, at least in our integration tests. See the screenshots in the failed run. The scope variables initialized in $onRouteChangeSuccess are not set when added to the view.

Note that calling onRouteChange a second time is a no-op because we only do work if the project name has changed.

I hope this finally fixes #2016.

@spadgett
Copy link
Member Author

[test]

1 similar comment
@spadgett
Copy link
Member Author

[test]

benjaminapetersen
benjaminapetersen reviewed Sep 13, 2017
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense to ensure it gets called at least once. Should we leave a comment indicating its a concession for tests, or think thats unnecessary?

@spadgett
Copy link
Member Author

Thanks @benjaminapetersen, I added a comment

@spadgett
Copy link
Member Author

Two successful runs so far, no failures:

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/174/
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/175/

@spadgett
Copy link
Member Author

Unrelated flake. [test]

  1. User adds a template to a project after creating a new project using the Import YAML tab should process and create the objects in the template
  • Expected false to be true.

@openshift-bot
Copy link

Evaluated for origin web console test up to 60e5805

@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/177/) (Base Commit: f3fcba9) (PR Branch Commit: 60e5805)

@spadgett
Copy link
Member Author

Origin Web Console Test Results: SUCCESS >
(https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/177/) (Base Commit: f3fcba9) (PR Branch Commit: 60e5805)

3 successful runs, and one unrelated failure.

[merge][severity: blocker]

@openshift-bot
Copy link

openshift-bot commented Sep 13, 2017 •
edited

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/177/) (Base Commit: f3fcba9) (PR Branch Commit: 60e5805)

@openshift-bot
Copy link

Evaluated for origin web console merge up to 60e5805

@spadgett spadgett mentioned this pull request Sep 13, 2017
Merged
@openshift-bot openshift-bot merged commit 22e371a into openshift:master Sep 13, 2017
@spadgett spadgett deleted the fix-nav-test-flake branch September 13, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spadgett @openshift-bot @benjaminapetersen