Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview instance row improvements #2174

Merged

Conversation

spadgett
Copy link
Member

  • Show documentation URL
  • Show support URL
  • Add a delete action to failed deployment alerts
  • Truncate long text in alert messages

openshift web console 2017-09-26 14-06-39

@rhamilto @ncameronbritt

@ncameronbritt
Copy link

Looks good. I wonder if we shouldn't think about changing "Learn More" to "View Documentation" so that it's clearer where that link goes.

@spadgett
Copy link
Member Author

I wonder if we shouldn't think about changing "Learn More" to "View Documentation" so that it's clearer where that link goes.

We can do that. Should we change the wizard link text, too? It currently says "Learn More"

@ncameronbritt
Copy link

I think in the wizard link too. "Learn More" is vague.

@spadgett
Copy link
Member Author

I think in the wizard link too. "Learn More" is vague.

OK, makes sense. I'll tackle the catalog change in a separate PR since it's another repo anyway.

@ncameronbritt
Copy link

Not suggesting we tackle this now, but we use "Learn More" to link to openshift documentation throughout the console.

But here I think there's value in making the distinction between documentation and support clear.

@spadgett
Copy link
Member Author

@ncameronbritt I agree. It's only in one place in the catalog, so I just made the change there, too.

@spadgett spadgett force-pushed the overview-instance-links-actions branch 2 times, most recently from 02eab2a to 43e8d6a Compare September 26, 2017 19:06
@spadgett
Copy link
Member Author

Updated the link text and switched to the learn-more-inline console class for consistency. It does change the font size. @ncameronbritt Look OK or should we change back to normal font size here?

openshift web console 2017-09-26 15-04-53

@ncameronbritt
Copy link

@spadgett I know I already approved, but I think I like the larger font size for those links. I feel like they serve a slightly different function in this context as the other "learn more" links that we have in the console.

* Show documentation URL
* Show support URL
* Add a delete action to failed deployment alerts
* Truncate long text in alert messages
@spadgett spadgett force-pushed the overview-instance-links-actions branch from 43e8d6a to 2bd951f Compare September 26, 2017 20:21
@spadgett
Copy link
Member Author

OK, back to normal font size with some small fixes for mobile styles.

@spadgett
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 2bd951f

@openshift-bot
Copy link

openshift-bot commented Sep 26, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/273/) (Base Commit: c6db605) (PR Branch Commit: 2bd951f)

@openshift-bot openshift-bot merged commit d8d6ca4 into openshift:master Sep 26, 2017
@spadgett spadgett deleted the overview-instance-links-actions branch September 27, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants