Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvFrom Copy Fixes #2211

Merged
merged 1 commit into from Oct 5, 2017
Merged

Conversation

cdcabrera
Copy link
Contributor

Copy updates related to #2182 and comments within #2198

screen shot 2017-10-03 at 5 24 18 pm

Copy updates for consistency
@spadgett
Copy link
Member

spadgett commented Oct 4, 2017

[test]

@openshift-bot
Copy link

Evaluated for origin web console test up to a0b1615

Copy link
Member

@beanh66 beanh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/278/) (Base Commit: a9de5c9) (PR Branch Commit: a0b1615)

@spadgett
Copy link
Member

spadgett commented Oct 5, 2017

[merge]

1 similar comment
@spadgett
Copy link
Member

spadgett commented Oct 5, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to a0b1615

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/313/) (Base Commit: 5017f92) (PR Branch Commit: a0b1615)

@openshift-bot openshift-bot merged commit 8af5164 into openshift:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants