Special case some humanized reasons codes #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BackOff -> Back-off (instead of "Back off") * OAuth -> OAuth (instead of "O auth") Used in the events page, notification drawer, and for pod status, which shows failed container reason codes.
|
/assign @benjaminapetersen |
openshift-ci-robot
added
the
size/M
|
|
jeff-phillips-18
approved these changes
Oct 13, 2017
|
@jeff-phillips-18 Can I get the lgtm comment? :) |
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in the events page, notification drawer, and for pod status, which
shows failed container reason codes.
@ncameronbritt Fixing your "back off" bug