Do not show binding parameters on the overview page #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
spadgett
reviewed
Oct 20, 2017
| @@ -9,6 +9,7 @@ angular.module('openshiftConsole').component('serviceInstanceBindings', { | |||
| ], | |||
| controllerAs: '$ctrl', | |||
| bindings: { | |||
| isOverview: '<?', | |||
There was a problem hiding this comment.
Maybe call this showParameters and flip the logic?
There was a problem hiding this comment.
We can but isOverview is already used in the sub-component (serviceBinding) so this is really just a pass thru to that.
|
@jeff-phillips-18 verified the fix works |
|
But we should still look at the margins on the provisioned service page:
|
|
Going to leave #2323 open to track the other display issue |
|
/lgtm |
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@jeff-phillips-18 dist mismatch |
jeff-phillips-18
force-pushed
the
parameters
branch
from
156555f
to
1584e0d
Compare
openshift-ci-robot
added
size/L
openshift-merge-robot
removed
the
lgtm
|
Rebased to fix dist issues. |
|
still some dist problems |
jeff-phillips-18
force-pushed
the
parameters
branch
from
1584e0d
to
2892ee1
Compare
openshift-ci-robot
added
size/M
|
Added visual changes for binding parameters as well. See discussion in openshift/origin-web-catalog#518
|
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2323