Update pipelines, secrets, quota and membership page headers to be consistent #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with the rest of secondary level pages. Fixes openshift#779 Fixes openshift#780
sg00dwin
changed the title
spadgett
requested changes
Nov 2, 2016
| @@ -5,30 +5,32 @@ | |||
| <div class="middle-container"> | |||
| <div class="middle-header"> | |||
| <div class="container-fluid"> | |||
| <breadcrumbs breadcrumbs="breadcrumbs"></breadcrumbs> | |||
There was a problem hiding this comment.
If you remove the breadcrumbs from the view, we should also take the breadcrumbs out of the controller.
| @@ -6,18 +6,19 @@ | |||
| <div class="middle-container"> | |||
| <div class="middle-header"> | |||
| <div class="container-fluid"> | |||
| <breadcrumbs breadcrumbs="breadcrumbs"></breadcrumbs> | |||
There was a problem hiding this comment.
If you remove the breadcrumbs from the view, we should also take the breadcrumbs out of the controller.
spadgett
approved these changes
Nov 2, 2016
|
[merge] |
|
Evaluated for origin web console merge up to 7897cc5 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/638/) (Base Commit: 00eb12f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the rest of secondary level pages.
Fixes #779
Fixes #780
@spadgett PTAL