Improve attach storage and add config file validation #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
spadgett
force-pushed
the
improve-path-validation
branch
from
dba1145
to
70fbdb5
Compare
|
hold, found a small bug |
spadgett
force-pushed
the
improve-path-validation
branch
from
70fbdb5
to
04c0afd
Compare
|
Updated to fail validation on values that are exactly @jwforres please take another look |
Correctly validate paths on the client when checking key/path items in a config map or secret volume. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1397788 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1397789
spadgett
force-pushed
the
improve-path-validation
branch
from
04c0afd
to
619d346
Compare
|
Added volume name validation as well while in the code. |
spadgett
changed the title
spadgett
force-pushed
the
improve-path-validation
branch
from
2041442
to
6192f1c
Compare
spadgett
force-pushed
the
improve-path-validation
branch
from
6192f1c
to
744bc0b
Compare
|
[merge] |
|
Evaluated for origin web console merge up to 744bc0b |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/760/) (Base Commit: 2a982a1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly validate paths on the client when checking key/path items for a config map or secret volume.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1397788
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1397789
@jwforres PTAL