Make "Show system roles" checkbox label clickable #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
Dec 8, 2016
| type="checkbox" | ||
| class="toggle-hidden" | ||
| ng-click="showAllRoles($event)"> | ||
| Show hidden roles <a href="" |
There was a problem hiding this comment.
Is nesting the under the label going to cause clicking on the ? icon to check/uncheck the box? I wouldn't expect that behavior.
Also show the tooltip on hover for consistency with other tooltips.
spadgett
force-pushed
the
show-system-roles-checkbox
branch
from
9aca569
to
c9ee4f4
Compare
|
@jwforres updated |
jwforres
approved these changes
Dec 8, 2016
|
[merge] |
|
Evaluated for origin web console merge up to c9ee4f4 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/828/) (Base Commit: eee4d13) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also show the tooltip on hover for consistency with other tooltips.
@jwforres