Bug 1400775 - Disable the Create button when Configuration File field didn't pass the validation check

[jhadvig]

@spadgett PTAL

[spadgett]

I noticed a typo here in the view:

        <osc-file-input
          if="dockercfg-file-input"
          model="newSecret.data.dockerConfig"
          drop-zone-id="docker-config"
          help-text="Upload a .dockercfg or .docker/config.json file"
          show-values="false"
          required="true"></osc-file-input>

if should be id, correct?

[jhadvig]

Indeed it should.. will update right away

[spadgett]

We should be calling $setValidity in the controller to mark the field invalid, and then just check $invalid here as before. For instance, give the input name="dockerConfig", then in the controller (untested)

        var updateEditorMode = _.debounce(function(){
          try {
            JSON.parse($scope.newSecret.data.dockerConfig);
            $scope.$apply(function() {
              $scope.secretForm.dockerConfig.$setValidity('validJSON', true);
            });
          } catch (e) {
            $scope.$apply(function() {
              $scope.secretForm.dockerConfig.$setValidity('validJSON', false);
            });
          }
        }, 300, {
          'leading': true
        });

Use $scope.$apply because the function is debounced.

In the view, show the error with

        <div class="has-warning" ng-if="secertForm.dockerConfig.$error.validJSON">
          <span class="help-block">
            Configuration file should be valid JSON.
          </span>
        </div>

[spadgett]

@jhadvig approving per our discussion since we're using osc-file-input, which means we can't name in input.

I think we can add validation to osc-file-input in a follow-on.

[spadgett]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to 1793f9b

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/794/) (Base Commit: 6aabd72)